add INSTANCE_TYPE integration settings and lessen integration log spams #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-dubs
force-pushed
the
more-integration-settings
branch
from
2a394b2 to
f870470
Compare
a-dubs
force-pushed
the
more-integration-settings
branch
from
f870470 to
ab318ff
Compare
github-actions
bot
added
the
documentation
|
documented this new setting in |
holmanb
reviewed
Jan 27, 2025
| @@ -15,6 +15,9 @@ | |||
| # Run tests marked as unstable. Expect failures and dragons. | |||
| RUN_UNSTABLE = False | |||
|
|
|||
| # Instance type - is cloud specific. E.g., m6in.32xlarge on AWS/EC2 | |||
| INSTANCE_TYPE: Optional[str] = None | |||
There was a problem hiding this comment.
I'm confused, what's up with line 35? I recall this being added before, but I never used it.
a-dubs
force-pushed
the
more-integration-settings
branch
from
ab318ff to
730b9ed
Compare
holmanb
approved these changes
Jan 28, 2025
holmanb
force-pushed
the
more-integration-settings
branch
from
6d34fed to
fcb534a
Compare
|
One of the commits was already merged in a different PR so I removed it. Thanks for this @a-dubs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
N/A
Separate commits, plz rebase 💙
Additional Context
This will allow for manually specifying instance types when needing to reproduce certain bugs or test certain instance types (like Baremetal!)
Also, put some duct tape over the metaphorical mouths of urllib3 and botocore for integration tests to lessen log spam.
Test Steps
Run an integration test locally with INSTANCE_TYPE specified:
Merge type