AWS infrastructure provider template #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
reviewed
Jul 17, 2024
ktsakalozos
reviewed
Aug 8, 2024
neoaggelos
reviewed
Aug 15, 2024
ktsakalozos
reviewed
Aug 19, 2024
eaudetcobello
force-pushed
the
KU-893/aws-provider
branch
from
e027e77
to
b47b384
Compare
- Change service CIDR block to match our standard range - Create a bastion by default - Copy cluster bootstrap/join overrides to control-plane - Remove unneeded prerunCommands - Remove tolerations that don't apply to our setup (kubernetes.io/master) - Add args from default provider template to aws-cloud-controller-manager args - Restore some RBAC rules from default provider template
no hardcoded defaults, empty variables by default, use new nodeName field to specify node name
eaudetcobello
force-pushed
the
KU-893/aws-provider
branch
from
b47b384
to
0f07038
Compare
bschimke95
commented
Aug 26, 2024
There was a problem hiding this comment.
LGTM only minor nits
BTW, @eaudetcobello you need to approve this, I cannot since it is my own PR
eaudetcobello
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.