-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollout upgrade integration test #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just comments. I don't feel like I can give better feedback
test/e2e/data/infrastructure-docker/cluster-template-upgrades.yaml
Outdated
Show resolved
Hide resolved
12ea578
to
667b389
Compare
b160fd2
to
b9398fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments around structure
0894d27
to
4d687c5
Compare
7b14410
to
35491a1
Compare
40ac014
to
a1d4fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks a lot @bschimke95! Just some minor comments and questions.
test/e2e/data/infrastructure-docker/cluster-template-md-remediation.yaml
Show resolved
Hide resolved
test/e2e/data/infrastructure-docker/cluster-template-upgrades.yaml
Outdated
Show resolved
Hide resolved
test/e2e/data/infrastructure-docker/cluster-template-upgrades.yaml
Outdated
Show resolved
Hide resolved
The upgrade test passes, the other tests are known to be faulty/flaky and will be fixed as follow-up work. |
Summary
Adds a test that creates a HA workload cluster and upgrades it from 1.29 Kubernetes to 1.30.
Implementation details
snap install
. That's why we build two different docker images and replace the infrastructure reference accordingly along with the upgrade. On other infra providers we would simply change the version and not the image.Notes
This tests require canonical/microcluster#197 to land in microcluster and canonical/k8s-snap#560 and canonical/k8s-snap#562 to land in k8s-snap.