Add in-place upgrade proposal #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Jul 29, 2024
bschimke95
reviewed
Jul 29, 2024
bschimke95
reviewed
Jul 29, 2024
ktsakalozos
reviewed
Jul 30, 2024
ktsakalozos
reviewed
Jul 30, 2024
bschimke95
reviewed
Jul 30, 2024
neoaggelos
reviewed
Aug 1, 2024
There was a problem hiding this comment.
This is great @berkayoz. Finished my first pass and left some comments for consideration
| * `k8sd.io/in-place-upgrade-failure` annotation on the `Machine` would be added/updated with the failure message | ||
| * `k8sd.io/in-place-upgrade-status` annotation on the `Machine` would be added/updated with `failed` | ||
|
|
||
| The reconciler should ignore the upgrade if `k8sd.io/in-place-upgrade-status` is already set to `in-progress` on the machine. |
There was a problem hiding this comment.
Also, it would probably be wise to have a configurable (?) parallelism for multiple machines at once. With rollout replace, machines are rotated one by one, we might want to mimic the same behaviour here (== if any other in-place upgrade is already in progress, just requeue the request).
--------- Co-authored-by: Homayoon (Hue) Alimohammadi <[email protected]>
|
follow up: cluster-wide in-place upgrade PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in-place upgrade proposal