Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hardcoded Go version to get go from go.dev/dl in Dockerfile #41

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

eaudetcobello
Copy link
Contributor

old pattern could result in the following match which would cause a 404 during a docker build:

❯ curl -s https://go.dev/dl/ | grep -o "go1.22.*.linux-amd64.tar.gz"
go1.22.6.linux-amd64.tar.gz">go1.22.6.linux-amd64.tar.gz

old pattern could result in the following match which would cause a 404 during a docker build:

❯ curl -s https://go.dev/dl/ | grep -o "go1.22.*.linux-amd64.tar.gz"
go1.22.6.linux-amd64.tar.gz">go1.22.6.linux-amd64.tar.gz
@eaudetcobello eaudetcobello requested a review from a team as a code owner August 15, 2024 18:45
Copy link

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this @eaudetcobello ?

templates/docker/install-go.sh Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello changed the title use regular expression to get go from go.dev/dl in Dockerfile use hardcoded Go version to get go from go.dev/dl in Dockerfile Aug 21, 2024
templates/docker/Dockerfile Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello merged commit 486c239 into main Aug 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants