Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize e2e tests #50

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Stabilize e2e tests #50

merged 5 commits into from
Sep 13, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Sep 4, 2024

Some e2e test improvements. See comments for each fix

@bschimke95 bschimke95 marked this pull request as ready for review September 6, 2024 12:29
@bschimke95 bschimke95 requested a review from a team as a code owner September 6, 2024 12:29
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
run: |
sudo docker load -i k8s-snap-image-old.tar
- name: Load k8s-snap new image
if: matrix.ginkgo_focus == 'Workload cluster upgrade'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all non-upgrade images use the k8s-snap:dev-old image. I introduced this bug in the last PR

Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to remove the tmate step

@bschimke95 bschimke95 merged commit 00b2a6b into main Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants