Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in-place upgrade e2e tests #53

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Add in-place upgrade e2e tests #53

merged 4 commits into from
Sep 12, 2024

Conversation

berkayoz
Copy link
Member

@berkayoz berkayoz commented Sep 9, 2024 •
edited
Loading

  • Fixes missing rbac roles (Caused by a missing new line)
  • Adds e2e tests for in-place upgrades on control-plane machines
  • Adds e2e tests for in-place upgrades on worker machines

Note: The PR currently does not add the test to the github actions to run on PRs due to the cilium issue in main branch. As a workaround we could update hack/build-e2e-images.sh to point to the autoupdate/moonray.

@berkayoz berkayoz marked this pull request as ready for review September 10, 2024 06:03
@berkayoz berkayoz requested a review from a team as a code owner September 10, 2024 06:03
bschimke95
bschimke95 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @berkayoz, some minor comments

bootstrap/controllers/upgrade_controller.go Show resolved Hide resolved
templates/docker/Dockerfile Show resolved Hide resolved
test/e2e/in_place_upgrade_test.go Show resolved Hide resolved
bschimke95
bschimke95 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eaudetcobello
eaudetcobello requested changes Sep 10, 2024
View reviewed changes
test/e2e/helpers.go Outdated Show resolved Hide resolved
test/e2e/helpers.go Outdated Show resolved Hide resolved
eaudetcobello
eaudetcobello requested changes Sep 10, 2024
View reviewed changes
test/e2e/in_place_upgrade_test.go Outdated Show resolved Hide resolved
eaudetcobello
eaudetcobello approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@berkayoz berkayoz merged commit 29e8770 into main Sep 12, 2024
3 of 7 checks passed
@berkayoz berkayoz deleted the KU-1209/ipu-e2e-test branch September 12, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

@eaudetcobello eaudetcobello eaudetcobello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berkayoz @bschimke95 @eaudetcobello