Add Certs Refresh Proposal #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/002-refresh-certs.md
Outdated
|
|
||
| The controller will share the status similar to the control plane nodes by updating | ||
| the `k8sd.io/refresh-certificates-status` annotation with the status of the renewal. | ||
| The value of this annotation will be the same as the control plane nodes. |
There was a problem hiding this comment.
Thinking about edge cases, what are we going to do when a node gets stuck in in progress. Do we timeout and try again after some time?
There was a problem hiding this comment.
We can handle cases where the request times out or fails by requeuing the event and retrying after a short delay.
berkayoz
reviewed
Sep 10, 2024
bschimke95
reviewed
Sep 13, 2024
berkayoz
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.