Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt integration tests to reuse the packed charm #42

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

arturo-seijas
Copy link
Collaborator

Adapt the integration tests to reuse the exisintg charm artifact as per canonical/operator-workflows#162

weiiwang01
weiiwang01 previously approved these changes Jul 24, 2023
@github-actions
Copy link
Contributor

Test coverage for 48755af

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           201     18     41      9    89%   126-129, 157-158, 178-179, 198, 239-241, 255->266, 274-278, 352->355, 377, 390, 399->402, 477
src/file_reader.py      17      0      6      0   100%
----------------------------------------------------------------
TOTAL                  218     18     47      9    90%

Static code analysis report

Run started:2023-07-24 10:11:08.265049

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1294
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas merged commit c5e3102 into main Jul 24, 2023
19 checks passed
@arturo-seijas arturo-seijas deleted the reuse-charm-in-tests branch July 24, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants