Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #66

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Add pull request template #66

merged 7 commits into from
Jan 4, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Jan 4, 2024

Add template for the pull requests

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 62 files.

Valid Invalid Ignored Fixed
0 17 45 0
Click to see the invalid file list
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • content-cache_rock/entrypoint.sh
  • content-cache_rock/rockcraft.yaml
  • generate-src-docs.sh
  • metadata.yaml
  • pyproject.toml
  • src/charm.py
  • src/file_reader.py
  • tests/conftest.py
  • tests/integration/any_charm.py
  • tests/integration/conftest.py
  • tests/integration/test_core.py
  • tests/unit/test_charm.py
  • tox.ini
  • trivy.yaml

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 62 files.

Valid Invalid Ignored Fixed
16 1 45 0
Click to see the invalid file list
  • generate-src-docs.sh

generate-src-docs.sh Show resolved Hide resolved
arturo-seijas and others added 2 commits January 4, 2024 10:34
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Test coverage for 6835700

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           201     18     41      9    89%   126-129, 157-158, 178-179, 198, 239-241, 255->266, 274-278, 352->355, 377, 390, 399->402, 477
src/file_reader.py      17      0      6      0   100%
----------------------------------------------------------------
TOTAL                  218     18     47      9    90%

Static code analysis report

Run started:2024-01-04 09:51:16.264474

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1294
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gregory-schiano
Copy link

Can you add a small description to the PR ? Even if that's trivial

@arturo-seijas arturo-seijas merged commit 764e827 into main Jan 4, 2024
19 checks passed
@arturo-seijas arturo-seijas deleted the add-pr-template branch January 4, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants