Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus exporter to ROCK #67

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add Prometheus exporter to ROCK #67

merged 3 commits into from
Jan 5, 2024

Conversation

gtrkiller
Copy link
Contributor

Applicable spec: ISD043

Overview

Add the NGINX Prometheus Exporter as a layer to the content-cache ROCK.

Rationale

Simplify the charm, reduce container amount, address possible securities issues caused by docker images.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@gtrkiller gtrkiller requested a review from a team as a code owner January 4, 2024 18:11
amandahla
amandahla previously approved these changes Jan 4, 2024
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Test coverage for 4f119cd

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           186     11     39      8    92%   136-137, 157-158, 177, 218-220, 234->246, 318->321, 343, 356, 365->368, 443
src/file_reader.py      17      0      6      0   100%
----------------------------------------------------------------
TOTAL                  203     11     45      8    92%

Static code analysis report

Run started:2024-01-05 14:36:19.231684

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1257
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtrkiller gtrkiller merged commit bca3a66 into main Jan 5, 2024
19 checks passed
@gtrkiller gtrkiller deleted the prom_exps branch January 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants