Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redeployment doc #75

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Add redeployment doc #75

merged 11 commits into from
Apr 30, 2024

Conversation

gtrkiller
Copy link
Contributor

Applicable spec:

Overview

Add a new document to specify redeployment requirements.

Rationale

There exists a need to clarify and standardize what to do in a redeployment situation.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

arturo-seijas
arturo-seijas previously approved these changes Apr 23, 2024
mthaddon
mthaddon previously approved these changes Apr 23, 2024
yanksyoon
yanksyoon previously approved these changes Apr 25, 2024
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, thank you!

docs/reference/charm-redeployment.md Outdated Show resolved Hide resolved
@mthaddon mthaddon dismissed stale reviews from yanksyoon, arturo-seijas, and themself via a26c2cd April 29, 2024 13:17
mthaddon
mthaddon previously approved these changes Apr 29, 2024
yanksyoon
yanksyoon previously approved these changes Apr 29, 2024
Thanhphan1147
Thanhphan1147 previously approved these changes Apr 29, 2024
yanksyoon
yanksyoon previously approved these changes Apr 29, 2024
yanksyoon
yanksyoon previously approved these changes Apr 29, 2024
mthaddon
mthaddon previously approved these changes Apr 29, 2024
amandahla
amandahla previously approved these changes Apr 29, 2024
@yanksyoon yanksyoon dismissed stale reviews from mthaddon and themself via e671bcf April 29, 2024 15:14
Copy link
Contributor

Test coverage for d9123f7

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py           186     11     39      8    92%   145-146, 166-167, 186, 226-228, 242->254, 326->329, 351, 364, 373->376, 451
src/file_reader.py      17      0      6      0   100%
----------------------------------------------------------------
TOTAL                  203     11     45      8    92%

Static code analysis report

Run started:2024-04-30 15:26:22.680481

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1251
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@mthaddon mthaddon requested a review from yanksyoon April 30, 2024 15:48
@yanksyoon yanksyoon merged commit 48a7da9 into main Apr 30, 2024
19 checks passed
@yanksyoon yanksyoon deleted the redep_doc branch April 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants