feat: mark ServiceFactory.set_kwargs() as deprecated (#660)

This moves set_kwargs() from pending deprecation to deprecated. It
doesn't change any behaviour other than the type of warning that it
raises.

craft_application/services/service_factory.py

@@ -157,11 +157,11 @@ def set_kwargs(
     ) -> None:
         """Set up the keyword arguments to pass to a particular service class.
 
-        PENDING DEPRECATION: use update_kwargs instead
+        DEPRECATED: use update_kwargs instead
         """
         warnings.warn(
-            PendingDeprecationWarning(
-                "ServiceFactory.set_kwargs is pending deprecation. Use update_kwargs instead."
+            DeprecationWarning(
+                "ServiceFactory.set_kwargs is deprecated. Use update_kwargs instead."
             ),
             stacklevel=2,
         )

docs/reference/changelog.rst

@@ -7,6 +7,14 @@ Changelog
 5.0.0 (2025-Mon-DD)
 -------------------
 
+Services
+========
+
+- Setting the arguments for a service using the service factory's ``set_kwargs`` is
+  deprecated. Use ``update_kwargs`` instead or file `an issue
+  <https://github.com/canonical/craft-application/issues/new?template=bug.yaml>`_
+  if you still need this method.
+
 Testing
 =======
 

tests/unit/services/test_service_factory.py

@@ -136,7 +136,7 @@ def __new__(cls, *args, **kwargs):
         app_metadata, project=fake_project, PackageClass=MockPackageService
     )
 
-    with pytest.warns(PendingDeprecationWarning):
+    with pytest.warns(DeprecationWarning):
         factory.set_kwargs("package", **kwargs)
 
     check.equal(factory.package, MockPackageService.mock_class.return_value)