feat!(ProjectService): allow the ProjectService to work with Imagecraft #674
Conversation
lengau
force-pushed
the
work/imagecraft-partitions
branch
2 times, most recently
from
c6ad126 to
da33cbf
Compare
This makes it more obvious to a partitions-using application that it needs to override `get_partitions`
This should allow imagecraft to use the service
lengau
force-pushed
the
work/imagecraft-partitions
branch
from
68b56fd to
0a3a25a
Compare
| @@ -239,7 +239,7 @@ def _init_lifecycle_manager(self) -> LifecycleManager: | |||
| project_vars_part_name=self._project.adopt_info, | |||
| project_vars=self._project_vars, | |||
| track_stage_packages=True, | |||
| partitions=self._services.get("project").get_partitions(), | |||
| partitions=self._services.get("project").partitions, | |||
There was a problem hiding this comment.
nitpick: using self._services.get(Literal["project"]) is helping the typing interpreter (at least in my IDE) to understand the type of the returned object (and so to suggest methods and fields). That is a bit uglier though so maybe we should define a constants for the available services provided by craft-application?
PROJECT_SERVICE = Literal["project"]
There was a problem hiding this comment.
Which IDE are you using that's doing this? I'm not seeing this issue in pycharm or using the pyright LSP.
| assert project_data == expected | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "build_for", [arch.value for arch in craft_platforms.DebianArchitecture] + ["all"] | ||
| "build_for", [arch.value for arch in craft_platforms.DebianArchitecture] | ||
| ) | ||
| @pytest.mark.usefixtures("enable_partitions") | ||
| def test_expand_environment_stage_dirs( |
There was a problem hiding this comment.
note: I am confused about this test. I failed to understand why it is using the platform/build_for values as partition names.
There was a problem hiding this comment.
That's to test that we have variable/flexible partitions based on the platform. We're using the FakeProjectService from conftest.py here which does that. I've added a comment to explain.
make lint && make test?docs/reference/changelog.rst)?