Skip to content

Commit

Permalink
breaking(build_charm.yaml): Enable cache by default (#263)
Browse files Browse the repository at this point in the history
Cached builds will be used for release & integration tests, so that we
release the same *.charm file that is tested

Signed by Mykola & Jon in
https://docs.google.com/document/d/1Wt0ds4dEcih4cvHWkbvvALtqonC_D9crcNQteX34SUg/edit?pli=1&tab=t.0
  • Loading branch information
carlcsaposs-canonical authored Jan 17, 2025
1 parent 9948453 commit bfe6cc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/build_charm.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ jobs:
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
```
If you use
```yaml
with:
cache: true
```
remember to add your charm's branch(es) to charmcraftcache by running `ccc add` or by [opening an issue](https://github.com/canonical/charmcraftcache-hub/issues/new?assignees=&labels=add-charm&projects=&template=add_charm_branch.yaml&title=Add+charm+branch).
Unless you disable caching (with `cache: false`), remember to add your charm's branch(es) to charmcraftcache: https://github.com/canonical/charmcraftcache?tab=readme-ov-file#usage

### Required charmcraft.yaml syntax
Only [ST124 - Multi-base platforms in craft tools](https://docs.google.com/document/d/1QVHxZumruKVZ3yJ2C74qWhvs-ye5I9S6avMBDHs2YcQ/edit) "shorthand notation" syntax is supported
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/build_charm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,8 @@ on:
workflow_call:
inputs:
cache:
description: |
Whether to use cache for faster builds
Should be `false` for production builds
default: false
description: Whether to use cache for faster builds
default: true
type: boolean
artifact-prefix:
description: Charm packages are uploaded to GitHub artifacts beginning with this prefix
Expand Down

0 comments on commit bfe6cc9

Please sign in to comment.