patch(integration_test_charm.yaml): Add Allure "unknown" status for tests with missing results #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever,
dragomirp and
shayancanonical
taurus-forever
approved these changes
Jun 7, 2024
|
tested again with rebase on #179 on https://github.com/carlcsaposs-canonical/mysql-router-k8s-operator/actions/runs/9415095490/job/25935868156 (to test that if job is cancelled, that completed tests are reported as passed & only non-completed tests are cancelled) |
3 tasks
|
Opened upstream (allure-pytest) feature request: allure-framework/allure-python#821 to replace our custom pytest plugin |
phvalguima
approved these changes
Jun 7, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
Jun 7, 2024
…docs Follow up to #183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate default results with "unknown" status for every test so that if Allure report is missing (because runner set up failed or integration tests timed out) that those tests show up as "unknown" instead of being omitted from Allure report
Breaking change for Allure users (Allure is in beta & not part of public interface, hence
patchPR prefix instead ofbreaking):allure-pytest-collection-reportplugin now required, see .github/workflows/integration_test_charm_allure_beta.md