-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-5642: breaking(build_charm.yaml): Pack on self hosted runners #245
Closed
+12
−26
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
67ebf88
Test self hosted runner builds
dragomirp b6d8407
Try lists
dragomirp b63a40c
Install pipx
dragomirp 5ea4b88
Manually install pip
dragomirp 3a2d380
Pipx
dragomirp 21b9f00
Revert manual pipx install
dragomirp 56519bb
Update apt
dragomirp a974eaf
Always install libpq
dragomirp a8d92a8
Tweak job name
dragomirp e4c17cd
Merge branch 'main' into self-hosted-builders
dragomirp 85873c1
Run integration tests on self hosted
dragomirp c5b919e
Nonexistent dir
dragomirp d3f6afc
Install pipx
dragomirp c3ca37e
Remove clear disk job
dragomirp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ | |
|
||
logging.basicConfig(level=logging.INFO, stream=sys.stdout) | ||
RUNNERS = { | ||
craft.Architecture.X64: "ubuntu-latest", | ||
craft.Architecture.ARM64: "Ubuntu_ARM64_4C_16G_02", | ||
craft.Architecture.X64: ["self-hosted", "linux", "X64", "large", "jammy"], | ||
craft.Architecture.ARM64: ["self-hosted", "linux", "ARM64", "large", "jammy"], | ||
Comment on lines
+26
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can probably use other runner sizes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since charmcraft will spin lxd containers, we can also try using noble. |
||
} | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipx is missing from the IS runners and packages are not up to date.