-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Migrate docs #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8d4896e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for improving the code with all the feedback!
Test coverage for 9547a6c
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This feature is intended to be run at initial docs-migration stage, to later use git as the upstream source for documentation on discourse and/or charmhub.
Key features
It supports custom branch name support to allow branch names other than the default upload-charm-docs.Moving forward
Further partial PR can be supported for better UX, where a partial PR would contain migrations of successful files. This enhancement should include successful files migration, failed files logging and explicit user notification of failed migrations(related issue: #33 ).
To note
dry_run parameter has no effect.
Examples
Example run on indico-operator, Generated PR link
Example dry mode run on indico-operator.
Edit: