Skip to content

Commit

Permalink
feat: Reactive reconcile (#384)
Browse files Browse the repository at this point in the history
* pin branch

* add integration test for downscaling

* update changelog

* only run reactive integration test on push - REVERT ME

* enable tmate debug

* remove test_reactive for lxd

* fix test

* Revert "only run reactive integration test on push - REVERT ME"

This reverts commit 5332b56.

* remove outdated src-docs

* some changes

* explain TimeoutError

* pin correct commit

* clear queue before reconciling in setup

* regenerate src-docs
  • Loading branch information
cbartz authored Oct 9, 2024
1 parent 3778f19 commit 3c70637
Show file tree
Hide file tree
Showing 42 changed files with 1,113 additions and 3,599 deletions.
12 changes: 11 additions & 1 deletion docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@

### 2024-10-07

- Fixed a regression in the removal of leftover directories.
- Fixed the removal of proxy vars in `.env` file for LXD runners.
- Fixed a regression in the removal of leftover directories.
- Improved reconciliation for reactive runners.

### 2024-09-27

- Added job label validation when consuming a job from the message queue.

### 2024-09-24

- Added support for spawning a runner reactively.
- Fixed a bug where busy runners are killed instead of only idle runners.

### 2024-09-18

Expand Down
2 changes: 1 addition & 1 deletion generate-src-docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

lazydocs --no-watermark --output-path src-docs src
lazydocs --no-watermark --output-path src-docs src/*.py
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ cosl ==0.0.15
# juju 3.1.2.0 depends on pyyaml<=6.0 and >=5.1.2
PyYAML ==6.0.*
pyOpenSSL==24.2.1
github_runner_manager @ git+https://github.com/canonical/github-runner-manager.git@96178d52d4508775b7c6487c9168c529776426f1
github_runner_manager @ git+https://github.com/canonical/github-runner-manager.git@33bbaff42d7cc0f250006fdd08d24659cef364c9
26 changes: 11 additions & 15 deletions src-docs/charm.md → src-docs/charm.py.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<a href="../src/charm.py#L0"><img align="right" style="float:right;" src="https://img.shields.io/badge/-source-cccccc?style=flat-square"></a>

# <kbd>module</kbd> `charm`
# <kbd>module</kbd> `charm.py`
Charm for creating and managing GitHub self-hosted runner instances.

**Global Variables**
Expand Down Expand Up @@ -74,19 +74,6 @@ Catch common errors in actions.

---

<a href="../src/charm.py#L116"><img align="right" style="float:right;" src="https://img.shields.io/badge/-source-cccccc?style=flat-square"></a>

## <kbd>class</kbd> `ReconcileRunnersEvent`
Event representing a periodic check to ensure runners are ok.





---

<a href="../src/charm.py#L202"><img align="right" style="float:right;" src="https://img.shields.io/badge/-source-cccccc?style=flat-square"></a>

## <kbd>class</kbd> `GithubRunnerCharm`
Charm for managing GitHub self-hosted runners.

Expand All @@ -104,7 +91,7 @@ Charm for managing GitHub self-hosted runners.

<a href="../src/charm.py#L225"><img align="right" style="float:right;" src="https://img.shields.io/badge/-source-cccccc?style=flat-square"></a>

### <kbd>method</kbd> `__init__`
### <kbd>function</kbd> `__init__`

```python
__init__(*args: Any, **kwargs: Any) → None
Expand Down Expand Up @@ -165,3 +152,12 @@ Unit that this execution is responsible for.



---

## <kbd>class</kbd> `ReconcileRunnersEvent`
Event representing a periodic check to ensure runners are ok.





Loading

0 comments on commit 3c70637

Please sign in to comment.