Skip to content

Commit

Permalink
Merge branch 'main' into feat/reactive-spawning
Browse files Browse the repository at this point in the history
# Conflicts:
#	tests/integration/test_runner_manager_openstack.py
  • Loading branch information
cbartz committed Sep 20, 2024
2 parents 8bf16f6 + b937a40 commit 4141229
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/integration/test_runner_manager_openstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import json
from pathlib import Path
from secrets import token_hex
from typing import Iterator
from typing import AsyncGenerator, Iterator

import pytest
import pytest_asyncio
Expand Down Expand Up @@ -106,7 +106,7 @@ async def openstack_runner_manager_fixture(
proxy_config: ProxyConfig,
runner_label: str,
openstack_connection: OpenstackConnection,
) -> OpenStackRunnerManager:
) -> AsyncGenerator[OpenStackRunnerManager, None]:
"""Create OpenstackRunnerManager instance.
The prefix args of OpenstackRunnerManager set to app_name to let openstack_connection_fixture
Expand Down Expand Up @@ -144,7 +144,7 @@ async def openstack_runner_manager_fixture(
service_config=service_config,
)

return OpenStackRunnerManager(
yield OpenStackRunnerManager(
config=openstack_runner_manager_config,
)

Expand All @@ -155,13 +155,13 @@ async def runner_manager_fixture(
token: str,
github_path: GitHubPath,
log_dir_base_path: dict[str, Path],
) -> RunnerManager:
) -> AsyncGenerator[RunnerManager, None]:
"""Get RunnerManager instance.
Import of log_dir_base_path to monkeypatch the runner logs path with tmp_path.
"""
config = RunnerManagerConfig("test_runner", token, github_path)
return RunnerManager(openstack_runner_manager, config)
yield RunnerManager(openstack_runner_manager, config)


@pytest_asyncio.fixture(scope="function", name="runner_manager_with_one_runner")
Expand Down

0 comments on commit 4141229

Please sign in to comment.