Skip to content

Commit

Permalink
Fix check-runners juju action (#65)
Browse files Browse the repository at this point in the history
  • Loading branch information
yhaliaw committed Jun 5, 2023
1 parent 08bef36 commit 9117020
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,10 @@ def _on_check_runners_action(self, event: ActionEvent) -> None:
runner_info = runner_manager.get_github_info()

for runner in runner_info:
if runner.status == GitHubRunnerStatus.ONLINE:
if runner.status == GitHubRunnerStatus.ONLINE.value:
online += 1
runner_names.append(runner.name)
elif runner.status == GitHubRunnerStatus.OFFLINE:
elif runner.status == GitHubRunnerStatus.OFFLINE.value:
offline += 1
else:
# might happen if runner dies and GH doesn't notice immediately
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/test_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ def mock_get_latest_runner_bin_url():

def mock_get_github_info():
return [
RunnerInfo("test runner 0", GitHubRunnerStatus.ONLINE),
RunnerInfo("test runner 1", GitHubRunnerStatus.ONLINE),
RunnerInfo("test runner 2", GitHubRunnerStatus.OFFLINE),
RunnerInfo("test runner 3", GitHubRunnerStatus.OFFLINE),
RunnerInfo("test runner 0", GitHubRunnerStatus.ONLINE.value),
RunnerInfo("test runner 1", GitHubRunnerStatus.ONLINE.value),
RunnerInfo("test runner 2", GitHubRunnerStatus.OFFLINE.value),
RunnerInfo("test runner 3", GitHubRunnerStatus.OFFLINE.value),
RunnerInfo("test runner 4", "unknown"),
]

Expand Down

0 comments on commit 9117020

Please sign in to comment.