Skip to content

Commit

Permalink
Merge 8720c9c into c74701f
Browse files Browse the repository at this point in the history
  • Loading branch information
yhaliaw committed Sep 20, 2024
2 parents c74701f + 8720c9c commit aec8e7a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/integration/test_runner_manager_openstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import json
from pathlib import Path
from secrets import token_hex
from typing import Iterator
from typing import AsyncGenerator, Iterator

import pytest
import pytest_asyncio
Expand Down Expand Up @@ -105,7 +105,7 @@ async def openstack_runner_manager_fixture(
proxy_config: ProxyConfig,
runner_label: str,
openstack_connection: OpenstackConnection,
) -> OpenStackRunnerManager:
) -> AsyncGenerator[OpenStackRunnerManager, None]:
"""Create OpenstackRunnerManager instance.
The prefix args of OpenstackRunnerManager set to app_name to let openstack_connection_fixture
Expand Down Expand Up @@ -133,7 +133,7 @@ async def openstack_runner_manager_fixture(
ssh_debug_connections=None,
repo_policy_compliance=None,
)
return OpenStackRunnerManager(
yield OpenStackRunnerManager(
app_name, f"{app_name}-0", cloud_config, server_config, runner_config, service_config
)

Expand All @@ -144,13 +144,13 @@ async def runner_manager_fixture(
token: str,
github_path: GitHubPath,
log_dir_base_path: dict[str, Path],
) -> RunnerManager:
) -> AsyncGenerator[RunnerManager, None]:
"""Get RunnerManager instance.
Import of log_dir_base_path to monkeypatch the runner logs path with tmp_path.
"""
config = RunnerManagerConfig(token, github_path)
return RunnerManager("test_runner", openstack_runner_manager, config)
yield RunnerManager("test_runner", openstack_runner_manager, config)


@pytest_asyncio.fixture(scope="function", name="runner_manager_with_one_runner")
Expand Down

0 comments on commit aec8e7a

Please sign in to comment.