-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kernel on charm upgrade #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkandersson
previously approved these changes
Sep 11, 2023
jdkandersson
previously approved these changes
Sep 11, 2023
yanksyoon
previously approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!!
yhaliaw
dismissed stale reviews from yanksyoon and jdkandersson
via
September 12, 2023 03:37
3df927d
jdkandersson
previously approved these changes
Sep 12, 2023
yanksyoon
previously approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yhaliaw
dismissed stale reviews from yanksyoon and jdkandersson
via
September 12, 2023 04:19
db48389
Test coverage for db48389
Static code analysis report
|
jdkandersson
approved these changes
Sep 12, 2023
yanksyoon
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: NA
Overview
Combine the update_dependencies event and the reconcile event.
Update to dependencies and kernel occurs with the reconcile event.
Reboot of the charm is done with
juju-reboot
command.Rationale
By combine the update dependencies/kernel with reconcile, the runner spawned should have the latest dependencies and kernel. This should increase the security as the latest version of the dependencies are used.
Juju Events Changes
The update_dependencies custom event is removed.
The reconcile_runners custom event will update the dependencies and kernel as well.
The reconcile_runner_actions will update the dependencies but not the kernel. This is due to juju-reboot is not supported for juju actions:
Checklist
src-docs
urgent
,trivial
,complex
)