-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discourse-gatekeeper] Migrate charm docs #182
Conversation
…cs/reference/configurations.md,docs/reference/cos.md,docs/tutorial/quick-start.md,docs/tutorial/managing-resource-usage.md,docs/reference/arm64.md,docs/explanation/arm64.md,docs/how-to/change-path.md,docs/how-to/run-on-lxd.md,docs/explanation/charm-architecture.md,docs/index.md,docs/how-to/integrate-with-cos.md,docs/how-to/repo-policy.md,docs/how-to/change-token.md,docs/how-to/configure-denylist.md,docs/reference/actions.md
I see this notably adds a Contents section, the rest of the changes seem to remove and add the same thing... |
@merkata the change is related to whether there is a final new line or not. On discourse, trailing and leading new lines are removed so in our documentation files we shouldn't add trailing new lines if we want to avoid these kind of changes. It is hard to know in the action whether the trailing lines are or aren't intended so if we add them back in then we could equally get PRs adding them when they are not intended by the maintainers on GitHub |
Test coverage for dc3c8e3
Static code analysis report
|
…cs/reference/configurations.md,docs/reference/cos.md,docs/tutorial/quick-start.md,docs/tutorial/managing-resource-usage.md,docs/reference/arm64.md,docs/explanation/arm64.md,docs/how-to/change-path.md,docs/how-to/run-on-lxd.md,docs/explanation/charm-architecture.md,docs/index.md,docs/how-to/integrate-with-cos.md,docs/how-to/repo-policy.md,docs/how-to/change-token.md,docs/how-to/configure-denylist.md,docs/reference/actions.md (#182) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yhaliaw <[email protected]>
This pull request was autogenerated by discourse-gatekeeper to migrate existing documentation from server to the git repository.