-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ssh-debug integration test #193
Conversation
…ithub-runner-operator into feat/ssh-integration
…rator into feat/ssh-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks for the refactoring! One comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring! I have one nitpicky comment.
Co-authored-by: Christopher Bartz <[email protected]>
Test coverage for eb4d6db
Static code analysis report
|
Applicable spec: None.
Overview
This is a follow up PR for #176.
Rationale
In order to guarantee that the components tmate-ssh-server charm, the current github-runner-operator charm and action-tmate work together.
Juju Events Changes
None.
Module Changes
None.
Library Changes
None.
Checklist
src-docs
urgent
,trivial
,complex
)Documentation will be in a separate PR to reduce scope.