-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add secondary tokens #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to bind the token to the path or dynamically generate the path from the token. Currently we use a forked repo for many tests, which is in the @yhaliaw namespace. We cannot assume that our tokens have access to each other's namespaces.
EDIT: This is not necessary, as @yanksyoon reminded me that the fork is created dynamically in the token owner's ns.
In addition, we may want to stop passing tokens via the INTEGRATION_TEST_ARGS
secret, as this would mean sharing our tokens with each other, as someone has to fill in this value.
Test coverage for 44e3cf8
Static code analysis report
|
Applicable spec: N/A
Overview
Adds an option to have secondary tokens (CSV of PATs) to reduce chance of having rate limiting issues.
Rationale
To reduce test failures due to rate limiting.
Juju Events Changes
None.
Module Changes
None.
Library Changes
None.
Checklist
src-docs
urgent
,trivial
,complex
)