-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aproxy arm/amd revision fix #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbartz
approved these changes
Jan 22, 2024
arturo-seijas
approved these changes
Jan 22, 2024
Test coverage for 3ad0e74
Static code analysis report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: N/A
Overview
The revisions of aproxy are separate for each ARM and X84 architectures due to how snap store works.
Separate the two revisions.
Link to successful run: https://github.com/yanksyoon/selfhostedtest/actions/runs/7607632472/job/20717460214
Rationale
Just tested on ARM deployment, the current revision is fixed to 6, which is broken.
Juju Events Changes
None.
Module Changes
runner.py
now contains revision number constants for different aproxy architectures.Library Changes
None.
Checklist
src-docs
urgent
,trivial
,complex
)