Allow root disk as runner-storage

[yhaliaw]

Overview

The charm no longer warns about using juju machine root disk as runner storage.

Rationale

Allow juju machine root-disk as the runner-storage.

Checklist

• The charm style guide was applied
• The contributing guide was applied
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation is generated using src-docs
• The documentation for charmhub is updated.
• The PR is tagged with appropriate label (urgent, trivial, complex)

[github-actions]

Test coverage for 30a5576

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
src/charm.py                   453    109    115     25    74%   86-88, 112-113, 117-119, 157-159, 169->181, 179, 214-233, 247-249, 250->254, 278-282, 313, 393-398, 421, 438-439, 448-471, 491-496, 502-505, 512, 515-516, 532, 536-541, 586->589, 602-603, 605-606, 640-647, 671-672, 684-686, 701-702, 730-731, 733-734, 736-737, 811->813, 874-875, 891, 909-911, 915-917, 921
src/charm_state.py             138     18     22      3    86%   131-138, 221-224, 266-268, 279-280, 286-291, 302-304
src/errors.py                   39      0      0      0   100%
src/event_timer.py              45      9      6      1    73%   80, 100-103, 123-126
src/firewall.py                 43     25     10      0    38%   38-42, 64-67, 75-149
src/github_client.py            68      6     32      3    87%   124, 146, 158-165, 183->216
src/github_metrics.py           14      0      0      0   100%
src/github_type.py              50      0      0      0   100%
src/lxd_type.py                 37      0      2      0   100%
src/metrics.py                  73      2     10      1    96%   61->64, 170-171
src/metrics_type.py              6      0      0      0   100%
src/runner.py                  325     70     96     24    73%   45->47, 129, 256-257, 298-307, 331-336, 341, 361, 365-375, 424->427, 430-432, 439, 453, 463, 467, 469, 484, 518-523, 539-552, 563-602, 607, 645, 696-698, 702, 720, 755, 781, 786-798, 812, 817->819, 822-824
src/runner_logs.py              35      2      6      1    93%   62->61, 66-67
src/runner_manager.py          274     47     90      8    82%   122, 167-169, 182-183, 195-197, 203-208, 212-213, 223-224, 243, 286-287, 331-333, 398, 418-422, 447, 499-502, 538, 645-658, 668, 673-684
src/runner_manager_type.py      33      0      6      0   100%
src/runner_metrics.py          123      8     20      2    93%   147-148, 160, 191-192, 307-311
src/runner_type.py              47      0     10      0   100%
src/shared_fs.py               116     16     20      0    88%   108-109, 133-134, 217-218, 241-242, 254-255, 260-261, 267-268, 292-293
src/utilities.py                68      5     20      7    86%   74->76, 78->84, 91, 121, 135, 173, 226
------------------------------------------------------------------------
TOTAL                         1987    317    465     75    81%

Static code analysis report

Run started:2024-01-29 06:23:23.726674

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4338
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 12

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):