-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix units with stuck reconciliation #367
Merged
cbartz
merged 7 commits into
main
from
fix/unit-no-longer-performing-reconciliation-ISD-2172
Sep 11, 2024
Merged
Fix units with stuck reconciliation #367
cbartz
merged 7 commits into
main
from
fix/unit-no-longer-performing-reconciliation-ISD-2172
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbartz
changed the title
WIP - Fix units with stuck reconciliation
Fix units with stuck reconciliation
Sep 10, 2024
Test coverage for 402da2d
Static code analysis report
|
jdkandersson
approved these changes
Sep 10, 2024
arturo-seijas
approved these changes
Sep 10, 2024
erinecon
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes look good to me 👍
cbartz
deleted the
fix/unit-no-longer-performing-reconciliation-ISD-2172
branch
September 11, 2024 05:26
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
Libraries: Out of sync
trivial
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: n/a
Overview
1 Add a timeout command to the juju reconciliation event dispatch. We use 10 times the reconciliation interval as a heuristic.
2. Add a panel showing the average reconciliation interval (note that this is not the same as reconciliation duration)
Rationale
to prevent units that are no longer performing periodic reconciliations due to https://bugs.launchpad.net/juju/+bug/2055184
to help identify bad reconciliation scheduling.
Juju Events Changes
Reconciliation event now times out after 10 * reconciliation interval
Module Changes
charm.py
: pass in 10 * reconciliation interval as timeoutevent_timer
: make timeout argument non-optional and don't calculate fallbackLibrary Changes
Checklist
src-docs
urgent
,trivial
,complex
)