Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the docs in the quick docs on the label #374

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fix the docs in the quick docs on the label #374

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
331abf9
Fix the docs in the quick docs on the label
yhaliaw Sep 13, 2024
ed16327
Add link
yhaliaw Sep 13, 2024
d6c89c9
Update the README instruction.
yhaliaw Sep 18, 2024
8f6b30a
Fix the labels configuration docs
yhaliaw Sep 18, 2024
f7e7ad3
Merge branch 'main' into doc/fix-labels-in-quickstart
yhaliaw Sep 18, 2024
6006ef5
Change wording
yhaliaw Sep 19, 2024
fa25490
Merge branch 'main' into doc/fix-labels-in-quickstart
yhaliaw Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/tutorial/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ The charm will spawn new runners on a schedule. During this time, the charm will

Once the self-hosted runner is available on GitHub, it can be used to run GitHub Actions jobs similar to runners provided by GitHub. The only difference being the label specified in the `runs-on` of a job.

The self-hosted runner managed by the charm will have the following labels: `self-hosted`, `linux`, and the application name.
The self-hosted runner managed by the charm will have the following labels: `self-hosted`, `linux`, the application name, and labels from the [`labels` charm configuration](https://charmhub.io/github-runner/configurations#labels).
yhaliaw marked this conversation as resolved.
Show resolved Hide resolved

In the above deployment, the application name was not specified, hence the default value of `github-runner` was used. As such, `github-runner` will be a label for the self-hosted runner managed by the application instance.

Expand Down
Loading