-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #376
Merged
Merged
Update docs #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat a note Capitalise Juju where appropriate Add a semicolon
Change "organization" to British spelling
Reformat link in the first sentence Link repo-policy-compliance README Format workplace_dispatch, push, and schedule as code Rewording
Capitalise Juju where appropriate Add "the" in the first sentence
Prerequisites --> Requirements Update the header levels
Prerequisites --> Requirements Update header levels Capitalisation Update broken link Reformat a note
Capitalisation Update spelling to British English Add commas
Capitalise Juju Reformat a note
Change last item to match the others in the list
Update to British English Add "be"
Capitalise Juju where appropriate Update last item in "GitHub API usage" list to be consistent with the other items
arturo-seijas
previously approved these changes
Sep 17, 2024
amandahla
reviewed
Sep 17, 2024
amandahla
previously approved these changes
Sep 17, 2024
erinecon
dismissed stale reviews from amandahla and arturo-seijas
via
September 17, 2024 13:29
40e92d9
Test coverage for 40e92d9
Static code analysis report
|
cbartz
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor question
amandahla
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Smaller doc changes after completing the deep dive into the GitHub runner charms.
Rationale
Juju Events Changes
None
Module Changes
None
Library Changes
None
Checklist
src-docs
urgent
,trivial
,complex
)