Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proxy for wget #78

Merged
merged 6 commits into from
Jul 5, 2023
Merged

fix: use proxy for wget #78

merged 6 commits into from
Jul 5, 2023

Conversation

yanksyoon
Copy link
Collaborator

@yanksyoon yanksyoon commented Jul 4, 2023

Tested command: wget https://github.com/mikefarah/yq/releases/download/v4.34.1/yq_linux_amd64 -O yq -e use_proxy=yes http_proxy=127.0.0.1:8080 https_proxy=127.0.0.1:8080

Output:

--2023-07-04 19:42:58--  http://http_proxy=127.0.0.1:8080/
Resolving http_proxy=127.0.0.1 (http_proxy=127.0.0.1)... failed: Name or service not known.
wget: unable to resolve host address 'http_proxy=127.0.0.1'
--2023-07-04 19:42:58--  http://https_proxy=127.0.0.1:8080/
Resolving https_proxy=127.0.0.1 (https_proxy=127.0.0.1)... failed: Name or service not known.
wget: unable to resolve host address 'https_proxy=127.0.0.1'
FINISHED --2023-07-04 19:42:58--
Total wall clock time: 1.3s
Downloaded: 1 files, 8.5M in 0.3s (27.6 MB/s)

Due to the stuck test runner (my bad!), attaching a screenshot to show that the tests pass.
image

@yanksyoon yanksyoon requested a review from a team as a code owner July 4, 2023 11:44
arturo-seijas
arturo-seijas previously approved these changes Jul 4, 2023
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthaddon
Copy link
Contributor

mthaddon commented Jul 4, 2023

I'm not sure how much impact this would have but the command will end up having -e before each portion rather than just one as you tested with. Also, I think we may need to take into account the no-proxy setting.

jdkandersson
jdkandersson previously approved these changes Jul 4, 2023
mthaddon
mthaddon previously approved these changes Jul 4, 2023
@yanksyoon yanksyoon dismissed stale reviews from mthaddon and jdkandersson via b82e003 July 4, 2023 14:24
@jdkandersson jdkandersson merged commit 015bd5e into main Jul 5, 2023
12 checks passed
@jdkandersson jdkandersson deleted the fix/wget_proxy branch July 5, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants