Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end test to workflow_dispatch actions #87

Merged
merged 11 commits into from
Jul 25, 2023

Conversation

devspyrosv
Copy link
Contributor

This PR, based on previous work by @weiiwang01, attempts to test the workflow dispatch action.

A new workflow workflow_dispatch_test.yaml is triggered in a separate job of e2e_test.yaml and its status is checked in intervals.

This PR should work after PR #84 is merged.

@weiiwang01 weiiwang01 marked this pull request as ready for review July 25, 2023 05:24
@weiiwang01 weiiwang01 requested a review from a team as a code owner July 25, 2023 05:24
@weiiwang01 weiiwang01 changed the title Test workflow dispatch action Add end-to-end test to workflow_dispatch actions Jul 25, 2023
yhaliaw
yhaliaw previously approved these changes Jul 25, 2023
Copy link
Collaborator

@yhaliaw yhaliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test coverage for 37684e8

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
src/charm.py                              378     88     90     22    74%   126-128, 183-191, 203-207, 276->280, 301-306, 316, 325-326, 335-346, 367-369, 377-380, 386, 389-390, 401, 412->429, 417-422, 439-440, 444-445, 450-453, 466-467, 469-470, 504-512, 523-524, 542-544, 547->exit, 551-553, 576-581, 599-600, 602-603, 605-606, 638->640, 700-701, 714, 727
src/errors.py                              22      0      0      0   100%
src/event_timer.py                         42      8      4      0    74%   96-99, 119-122
src/firewall.py                            43     25     10      0    38%   38-42, 64-67, 75-149
src/github_type.py                         36      0      0      0   100%
src/lxd_type.py                            38      0      2      0   100%
src/repo_policy_compliance_service.py       5      5      0      0     0%   4-14
src/runner.py                             249     29     74     21    84%   40->44, 188-195, 201-207, 266-271, 276, 296, 329->332, 335-337, 344, 358, 368, 372, 374, 389, 433-438, 448, 532, 567, 593, 598-610, 624, 642
src/runner_manager.py                     219     25     88      9    88%   204-206, 219-220, 232-234, 240-245, 249-250, 260-261, 277, 332, 357-361, 380, 398, 541, 561
src/runner_type.py                         52      0     12      0   100%
src/utilities.py                           68      6     20      8    84%   74->76, 78->84, 89-91, 119, 132, 167, 220
-----------------------------------------------------------------------------------
TOTAL                                    1152    186    300     60    81%

Static code analysis report

Run started:2023-07-25 08:03:35.767250

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2573
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 9

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01 weiiwang01 requested a review from yhaliaw July 25, 2023 09:05
@weiiwang01 weiiwang01 merged commit d67993f into main Jul 25, 2023
16 checks passed
@weiiwang01 weiiwang01 deleted the workflow-dispach-test branch July 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants