Expose block size setting. #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 16, 2023 14:56
Signed-off-by: Mathieu Borderé <[email protected]>
Signed-off-by: Mathieu Borderé <[email protected]>
Signed-off-by: Mathieu Borderé <[email protected]>
|
Looks like tests are a bit sad, not sure if related to this or just from not having built go-dqlite in a while. |
There's an unknown C symbol, should start succeeding once the dqlite package is built after an open PR in dqlite is merged (see original comment). |
|
Ah, that makes sense :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should start succeeding once canonical/dqlite#478 is merged.