Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redirect /accounts/me to the correct /accounts/{id} #43

Merged
merged 5 commits into from
Jul 18, 2024
Merged

feat: redirect /accounts/me to the correct /accounts/{id} #43

merged 5 commits into from
Jul 18, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Jul 12, 2024 •
edited
Loading

Description

This change introduces a small change to the endpoints where users are allowed to use /me to refer to their own accounts. It also cleans up some of the auth middleware code to be a bit reusable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review July 12, 2024 11:49
@kayra1 kayra1 requested a review from a team as a code owner July 12, 2024 11:49
ghislainbourgeois
ghislainbourgeois previously requested changes Jul 12, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
internal/api/middleware.go Outdated Show resolved Hide resolved
@ghislainbourgeois ghislainbourgeois requested a review from a team July 12, 2024 17:58
gruyaume
gruyaume requested changes Jul 16, 2024
View reviewed changes
internal/api/middleware.go Outdated Show resolved Hide resolved
internal/api/middleware.go Show resolved Hide resolved
internal/api/middleware.go Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume July 17, 2024 11:14
gruyaume
gruyaume requested changes Jul 17, 2024
View reviewed changes
internal/api/middleware.go Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume July 17, 2024 17:14
@kayra1 kayra1 dismissed ghislainbourgeois’s stale review July 18, 2024 06:04

he's on break for a while and this is blocking

@kayra1 kayra1 merged commit 38959c3 into main Jul 18, 2024
11 checks passed
@kayra1 kayra1 deleted the tlseng-290 branch July 18, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

@ghislainbourgeois ghislainbourgeois Awaiting requested review from ghislainbourgeois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayra1 @ghislainbourgeois @gruyaume