Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redirect page in the frontend #53

Merged
merged 1 commit into from
Aug 9, 2024
Merged

refactor: redirect page in the frontend #53

merged 1 commit into from
Aug 9, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Aug 9, 2024

Description

This PR moves the redirect mechanism from the backend to the frontend, which is a bit cleaner and fixes a bug where any url that ends with a slash (like /users/ or /alkshflgeh/) redirects to the certificate_requests page.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review August 9, 2024 12:59
@kayra1 kayra1 requested a review from a team as a code owner August 9, 2024 12:59
@kayra1 kayra1 changed the title fix: redirect page in the frontend refactor: redirect page in the frontend Aug 9, 2024
@kayra1 kayra1 merged commit 62a3e59 into main Aug 9, 2024
20 checks passed
@kayra1 kayra1 deleted the redirect branch August 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants