Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle errors when posting CSR's #55

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix: properly handle errors when posting CSR's #55

merged 4 commits into from
Aug 14, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Aug 13, 2024

Description

This change fixes #34 by properly handling returned errors and placing them in the form.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review August 13, 2024 11:18
@kayra1 kayra1 requested a review from a team as a code owner August 13, 2024 11:18
@kayra1 kayra1 requested a review from gruyaume August 14, 2024 06:08
@kayra1 kayra1 enabled auto-merge (squash) August 14, 2024 13:41
@kayra1 kayra1 merged commit 3d2ebfa into main Aug 14, 2024
10 checks passed
@kayra1 kayra1 deleted the duplicate-check branch August 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No feedback when Adding the same CSR twice through the frontend
3 participants
@kayra1 @ghislainbourgeois @gruyaume