Fix scenario test

canonical · Nov 12, 2024 · 59a7706 · 59a7706
1 parent 8fbcbdf
commit 59a7706
Showing 1 changed file with 4 additions and 23 deletions.
diff --git a/tests/scenario/test_config_reporting_enabled.py b/tests/scenario/test_config_reporting_enabled.py
@@ -14,13 +14,8 @@ def test_reporting_enabled(ctx):
     # WHEN config-changed fires
     out = ctx.run(ctx.on.config_changed(), state)
 
-    # THEN the config file is written WITHOUT the [analytics] section being rendered
-    simulated_pebble_filesystem = out.get_container("grafana").get_filesystem(ctx)
-    grafana_config_path = simulated_pebble_filesystem / "etc/grafana/grafana-config.ini"
-
-    config = ConfigParser()
-    config.read(grafana_config_path)
-    assert "analytics" not in config
+    # THEN the service layer does NOT include the "-disable-reporting" arg
+    assert "-disable-reporting" not in out.get_container("agent").layers.services["agent"].to_dict().command
 
 
 def test_reporting_disabled(ctx):
@@ -29,19 +24,5 @@ def test_reporting_disabled(ctx):
     # WHEN config-changed fires
     out = ctx.run(ctx.on.config_changed(), state)
 
-    # THEN the config file is written WITH the [analytics] section being rendered
-    simulated_pebble_filesystem = out.get_container("grafana").get_filesystem(ctx)
-    grafana_config_path = simulated_pebble_filesystem / "etc/grafana/grafana-config.ini"
-
-    config = ConfigParser()
-    config.read(grafana_config_path)
-    assert "analytics" in config
-    assert dict(config["analytics"]) == {
-        "reporting_enabled": "false",
-        "check_for_updates": "false",
-        "check_for_plugin_updates": "false",
-    }
-
-    # AND the "grafana" service is restarted
-    # TODO Does it make sense to check this if the charm under test's lifetime is only for the config-changed?
-    # TODO How to assert this?
+    # THEN the service layer INCLUDES the "-disable-reporting" arg
+    assert "-disable-reporting" in out.get_container("agent").layers.services["agent"].to_dict().command