use better locations for the positions files #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstathis
requested review from
sed-i,
Abuelodelanada,
rbarry82,
lucabello,
PietroPasotti and
simskij
as code owners
sed-i
approved these changes
Mar 24, 2023
Co-authored-by: Leon <[email protected]>
Co-authored-by: Leon <[email protected]>
Co-authored-by: Leon <[email protected]>
sed-i
added a commit
that referenced
this pull request
Apr 14, 2023
* Cleanup etc. (#90) * Fix metadata and snap usage (#91) * Class split (#92) * Make static_configs into a list (#96) * add option for tls insecure skip verify (#93) * Add dashboards handler (#97) * Scenario tests and machine charm rename (#99) * spelling errors (#100) * Clear machine metadata relations (#98) * Add tests for update-status (#101) * Type fixes (#102) * small fixes and scenarios (#103) * Machine charm lib (#95) * Feature/fix prop (#111) * LINT. Fix the grafana data iteration (#112) * plug extraction (#105) * Sub relation priority (#114) * Fix a possible JSON loading exception (#119) * purged grafana dashboard requirer (#117) * Fix labels (#120) * Use cosl for Rules and JujuTopology (#121) * Fix position files (#116) * top level documentation for cos_machine lib (#122) * Add juju-info itest (#123) * Snap plug logs (#124) * Loki shared logs monitoring (#125) * Rename cos-machine to cos-agent (#129) * wrong scope for grafana-dashboards-provider relation (#134) * FIX Grafana dashboards files are stored in a bad format (#139) * move on-refresh config to unit databag (#142) * Set BlockedStatus per relation (#141) * Be looser with finding snap plug mounts (#145) * Use an actual uuid4, alerts() is now a property everywhere (#151) * Replace DS_PROMETHEUS with prometheusds (#148) * Cleanup (#152) * use better locations for the positions files (#155) * added typing for metrics endpoint dict (#149) * Fix fstab parser (#159) * (cos-agent) Use peer relation data for communicating all principals' data (#160) * add support for the grafana cloud integrator charm (#150) Co-authored-by: Dylan Stephano-Shachter <[email protected]> Co-authored-by: awnn <[email protected]> Co-authored-by: Ryan Barry <[email protected]> Co-authored-by: PietroPasotti <[email protected]> Co-authored-by: Jose C. Massón <[email protected]> Co-authored-by: sed-i <[email protected]> Co-authored-by: Simon Aronsson <[email protected]> Co-authored-by: Luca Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#131
Solution
Each charm class defines a
positions_dirmethod to be called by the parent.Testing Instructions
Deploy on k8s and machine models and check that the positions files are in the correct place.
Release Notes
Fixed a bug where grafana-agent-k8s was not storing position files correctly.