Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in disk.rules #258

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix typo in disk.rules #258

merged 1 commit into from
Sep 29, 2023

Conversation

chanchiwai-ray
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray commented Sep 27, 2023 •
edited
Loading

Issue

The metric name node_filesystem_size_bytes_bytes appears to be incorrect due to typo. The correct metric name should be node_filesystem_size_bytes, and it can be verified from the source code of node exporter.

This is a regression from #186

Solution

Fix the typo: node_filesystem_size_bytes_bytes -> node_filesystem_size_bytes

Screenshot from 2023-09-26 12-30-20
Screenshot from 2023-09-26 12-30-32

Context

Prometheus alert rules

Testing Instructions

N/A

Release Notes

Fix typo in the Prometheus alert rules for disk

@sed-i
Copy link
Contributor

sed-i commented Sep 27, 2023

Thanks @chanchiwai-ray!
Would you be able to do the same in https://github.com/canonical/grafana-agent-operator ?

@chanchiwai-ray
Copy link
Contributor Author

Sure, I was not aware there's another repo for grafana-agent

rgildein
rgildein approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ray.

@sed-i
Copy link
Contributor

sed-i commented Sep 29, 2023

Seems like this is relevant only to the machine-charm.
Merging for now. We can cleanup in a followup PR.

@sed-i sed-i merged commit 36fe6aa into canonical:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@sed-i sed-i sed-i approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@lucabello lucabello Awaiting requested review from lucabello

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanchiwai-ray @sed-i @rgildein