Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly inform cloud endpoints about the snappy compression #261

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

simskij
Copy link
Member

@simskij simskij commented Oct 5, 2023

Issue

When using Grafana Agent with a logging backend other than Loki, we need to inform that backend about the payloads being compressed using snappy. Loki knows this is the case implicitly, but a third-party won't.

Solution

Add a Content-Encoding header to all outgoing requests.

Context

This is useful when integrating with, for instance, Vector or Logstash, as they otherwise have no way of knowing about the encoding/compression.

Testing Instructions

Release Notes

Properly advertise snappy compression when using the cloud integrator

@simskij simskij changed the title Advertise content encoding fix: properly inform cloud endpoints about the snappy compression Oct 5, 2023
@simskij simskij merged commit fc2faac into main Oct 5, 2023
@simskij simskij deleted the fix/advertise-content-encoding branch October 5, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants