Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label treatment of related charms #277

Merged
merged 4 commits into from
Feb 26, 2024
+643 −335
Merged

Fix label treatment of related charms #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1226c13
fetch-lib
sed-i Feb 23, 2024
e4d507f
Add cos-tool to charm
sed-i Feb 23, 2024
4890c2b
only insert labels that do not already exist
sed-i Feb 23, 2024
c2e6839
fetch-lib
sed-i Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ __pycache__/
.idea/
tests/integration/*-tester/lib/
.env
cos-tool*
4 changes: 2 additions & 2 deletions INTEGRATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ requires:
2. Obtain the library from charmhub:

```shell
charmcraft fetch-lib charms.loki_k8s.v0.loki_push_api
charmcraft fetch-lib charms.loki_k8s.v1.loki_push_api
```

3. Import the library and use it in your `src/charm.py`:

```python
from charms.loki_k8s.v0.loki_push_api import LogProxyConsumer
from charms.loki_k8s.v1.loki_push_api import LogProxyConsumer
...

class MyOperatorCharm(CharmBase):
Expand Down
8 changes: 8 additions & 0 deletions charmcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,11 @@ parts:
- pkg-config
- rustc
- cargo
cos-tool:
plugin: dump
source: .
build-packages:
- curl
override-pull: |
curl -L -O https://github.com/canonical/cos-tool/releases/latest/download/cos-tool-${CRAFT_TARGET_ARCH}
chmod +x cos-tool-*
Loading
Loading