Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use set_ports instead of open_port #289

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: use set_ports instead of open_port #289

merged 1 commit into from
Apr 17, 2024

Conversation

lucabello
Copy link
Contributor

Issue

open_port doesn't close ports; if the port changes on upgrades, the previous one isn't closed.

Solution

Use set_ports instead, as documented here.

@lucabello lucabello merged commit a45524a into main Apr 17, 2024
13 checks passed
@lucabello lucabello deleted the fix/open-port branch April 17, 2024 08:48
@lucabello lucabello mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkay mmkay mmkay approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@dstathis dstathis Awaiting requested review from dstathis

@IbraAoad IbraAoad Awaiting requested review from IbraAoad

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@sed-i sed-i Awaiting requested review from sed-i

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucabello @mmkay