Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing support #310

Merged
merged 10 commits into from
Aug 9, 2024
Merged

Tracing support #310

merged 10 commits into from
Aug 9, 2024

Conversation

PietroPasotti
Copy link
Contributor

This PR adds tracing support for grafana agent.

The goal is to configure grafana-agent in such a way that, when CMR'd with a Tempo backend (for example in cos-lite), grafana will forward any traces it receives to Tempo.

lib/charms/tempo_k8s/v1/charm_tracing.py Dismissed Show dismissed Hide dismissed
@PietroPasotti PietroPasotti marked this pull request as ready for review August 9, 2024 07:37
@PietroPasotti PietroPasotti requested a review from a team as a code owner August 9, 2024 07:37
Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of housekeeping complaints, other than that LGTM!

src/UNKNOWN.egg-info/PKG-INFO Outdated Show resolved Hide resolved
src/grafana_agent.py Outdated Show resolved Hide resolved
src/grafana_agent.py Show resolved Hide resolved
grafana_dashboards/node-exporter-full.json Outdated Show resolved Hide resolved
loki_alert_rules/grafana_agent_high_rate.rule Outdated Show resolved Hide resolved
prometheus_alert_rules/.wokeignore Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit d0c30e2 into main Aug 9, 2024
13 checks passed
@PietroPasotti PietroPasotti deleted the tracing-support branch August 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants