Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a binary PyYAML package #332

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Use a binary PyYAML package #332

merged 5 commits into from
Nov 22, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Nov 22, 2024

Issue

grafana agent charm may have quite some reldata to pipe through, and updating many relations may take some time, because the pyyaml we end up using isn't optimized.

Solution

Use a binary pyyaml package.

In tandem with canonical/grafana-agent-operator#212.

Drive-by:

  • fetch-lib

Context

canonical/cos-proxy-operator#150

Signed-off-by: Leon <[email protected]>
@sed-i sed-i marked this pull request as ready for review November 22, 2024 05:19
@sed-i sed-i requested a review from a team as a code owner November 22, 2024 05:19
This reverts commit bf07092.
@sed-i sed-i merged commit 2279191 into main Nov 22, 2024
13 checks passed
@sed-i sed-i deleted the sed-i-patch-1 branch November 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants