Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable reporting #202

Merged
merged 11 commits into from
Nov 20, 2024
Merged

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Nov 13, 2024

Issue

By default, grafana-agent sends out anonymous usage stats. This may be undesired in hardened environments.

Solution

Add a charm config option to disable the reporting (ref). The config option is named the same was as in the grafana-k8s charm (see grafana/354).

Drive-by fixes:

In tandem with:

Related:

Context

Testing Instructions

Deploy the following bundle:

default-base: [email protected]/stable
applications:
  ga20:
    charm: local:grafana-agent-1
    base: [email protected]/stable
  ga22:
    charm: local:grafana-agent-4
  u20:
    charm: ubuntu
    channel: latest/stable
    revision: 25
    base: [email protected]/stable
    num_units: 1
    to:
    - "22"
    constraints: arch=amd64
    storage:
      block: loop,100M
      files: rootfs,100M
  u22:
    charm: ubuntu
    channel: latest/stable
    revision: 25
    num_units: 1
    to:
    - "23"
    constraints: arch=amd64
    storage:
      block: loop,100M
      files: rootfs,100M
machines:
  "22":
    constraints: arch=amd64
    base: [email protected]/stable
  "23":
    constraints: arch=amd64
relations:
- - u20:juju-info
  - ga20:juju-info
- - u22:juju-info
  - ga22:juju-info

And curl the readiness endpoint:

> juju ssh ga20/1 curl localhost:12345/-/ready
Agent is Ready.
Connection to 10.3.37.71 closed.
> juju ssh ga22/1 curl localhost:12345/-/ready
Agent is Ready.
Connection to 10.3.37.193 closed.

Upgrade Notes

src/snap_management.py Outdated Show resolved Hide resolved
Base automatically changed from update-libs to main November 14, 2024 08:57
@sed-i sed-i force-pushed the feature/disable_reporting branch from e90ce13 to b74a94a Compare November 19, 2024 21:06
("strict", "amd64"): 94, # 0.40.4
("strict", "arm64"): 96, # 0.40.4
("classic", "amd64"): 95, # 0.40.4
("classic", "arm64"): 97, # 0.40.4
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sed-i sed-i marked this pull request as ready for review November 20, 2024 02:15
@sed-i sed-i requested a review from a team as a code owner November 20, 2024 02:15
@sed-i sed-i merged commit a5e2f57 into main Nov 20, 2024
13 checks passed
@sed-i sed-i deleted the feature/disable_reporting branch November 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants