install-plugin action #311
Conversation
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
| name: | ||
| type: string | ||
| description: | | ||
| Name of the plugin. Must be hosted at https://grafana.com/grafana/plugins`. |
There was a problem hiding this comment.
Would it make more sense to have url as the param?
That would lift the grafana.com restriction and the /plugins/{name}/versions/{version}/download assumption.
Or, if we want to keep the grafana.com restriction, then we could use grafana cli for that, which would be great help with uninstalling (which is currently missing in the PR).
| url = f"https://grafana.com/api/plugins/{name}/versions/{version}/download" | ||
| path = Path('/var/lib/grafana/plugins') |
There was a problem hiding this comment.
I would extract path and url to constants
| installed_plugins = [o.strip() for o in subprocess.getoutput("grafana cli plugin ls").splitlines()[1:]] | ||
| download_path.unlink() |
There was a problem hiding this comment.
I would put this inside a try...except blick
|
This is currently failing checks. Do we want to merge this? If so, we should fix the linting issues. I'm happy having this merged as-is, as it helps with provisioning plugins during initial deployment. Deleting them during day 2 operations can be done through the UI, so it does not feel as urgent. |
adds a development action to download and install into grafana a plugin.
Usage:
juju run grafana install-plugin some-plugin 1.0.0The script will grab the plugin from
grafana.com/api/plugins/some-plugin/versions/1.0.0/downloads, and unzip it into/var/lib/grafana/plugins, then restart grafana and the plugin should be there.Can't test it at the moment because
charmcraft packis bork on main.