Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback logo for identity providers #220

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Jan 31, 2024

On selecting an identity provider, we now show a generic lock icon instead of no icon. So the providers without a dedicated logo are displayed in the same way as Microsoft, GitHub, etc.

@edlerd edlerd requested a review from a team as a code owner January 31, 2024 11:48
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsklikas nsklikas merged commit 90f003f into main Jan 31, 2024
6 checks passed
@nsklikas nsklikas deleted the fallback-provider-logo branch January 31, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants