Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) update ui dependencies to latest #448

Closed
wants to merge 1 commit into from

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Jan 27, 2025

Done

  • update all UI dependencies to latest
  • fix issues from the new linter rules
  • exclude react 19, because react-components is not yet compatible.

@edlerd edlerd added the frontend This is a UI issue label Jan 27, 2025
@edlerd edlerd requested a review from a team as a code owner January 27, 2025 16:54
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (1e977a3) to head (0069dfe).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   70.77%   67.55%   -3.22%     
==========================================
  Files          15       15              
  Lines        1728     1871     +143     
==========================================
+ Hits         1223     1264      +41     
- Misses        442      537      +95     
- Partials       63       70       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BarcoMasile
BarcoMasile previously approved these changes Jan 27, 2025
Copy link
Contributor

@BarcoMasile BarcoMasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, watch out for the failing tests

@edlerd
Copy link
Contributor Author

edlerd commented Jan 27, 2025

LGTM, watch out for the failing tests

Thanks for the review. I think the failing check is wrongly concerned about coverage. Tests seem to be passing just fine.

natalian98
natalian98 previously approved these changes Jan 29, 2025
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your PR?

Signed-off-by: David Edler <[email protected]>
@edlerd edlerd dismissed stale reviews from natalian98 and BarcoMasile via 0069dfe January 29, 2025 17:18
@edlerd edlerd force-pushed the update-ui-dependencies branch from d88d1e3 to 0069dfe Compare January 29, 2025 17:18
@edlerd
Copy link
Contributor Author

edlerd commented Jan 29, 2025

Could you rebase your PR?

@natalian98 rebased and resolved the conflicts.

@edlerd
Copy link
Contributor Author

edlerd commented Feb 10, 2025

closing in favor of #467

@edlerd edlerd closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This is a UI issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants