-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps) update ui dependencies to latest #448
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 70.77% 67.55% -3.22%
==========================================
Files 15 15
Lines 1728 1871 +143
==========================================
+ Hits 1223 1264 +41
- Misses 442 537 +95
- Partials 63 70 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, watch out for the failing tests
Thanks for the review. I think the failing check is wrongly concerned about coverage. Tests seem to be passing just fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase your PR?
Signed-off-by: David Edler <[email protected]>
d88d1e3
to
0069dfe
Compare
@natalian98 rebased and resolved the conflicts. |
closing in favor of #467 |
Done