Fix woke errors and overall improvements #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
build-qol-improvements
branch
from
a5004e8 to
0c96473
Compare
kian99
changed the title
babakks
approved these changes
May 7, 2024
kian99
added a commit
to kian99/jaas-documentation
that referenced
this pull request
May 7, 2024
* Fix woke errors and overall improvements * Be more consistent in use of code blocks * Fix woke Woke doesn't like non ascii characters
Merged
kian99
added a commit
that referenced
this pull request
May 8, 2024
* Fixed links * Add ignore for woke * Fix woke errors and overall improvements (#39) * Fix woke errors and overall improvements * Be more consistent in use of code blocks * Fix woke Woke doesn't like non ascii characters * Remove extras added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds were failing with errors like
WARNING: Explicit markup ends without a blank line; unexpected unindent., this was due to the woke ignore comments. There was seemingly no clear way on fixing these issues until I stumbled on https://github.com/canonical/ubuntu-pro-docs/blob/main/readme.rst, this is the readme from the starter pack which explains several helpful things so I've decided to add it to this repo as well.I've also added an extra job to our Github action that will check that the html docs can be built without warnings/errors.